Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deploy blocker notification to open source channel #4670

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Aug 16, 2021

We are posting it in the #deployers room now, I am just moving it to the open source channel to involve contributors and changing the copy, since I don't think posting it twice is useful.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173930

Tests

None, is there a way to test this before merging?

QA Steps

  • Create a deploy blocker issue
  • Check it was posted in #expensify-open-soruce slack channel

@iwiznia iwiznia requested a review from a team as a code owner August 16, 2021 12:57
@iwiznia iwiznia self-assigned this Aug 16, 2021
@iwiznia iwiznia removed the request for review from a team August 16, 2021 12:57
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
@mountiny mountiny self-requested a review August 16, 2021 13:49
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roryabraham roryabraham merged commit 26e162b into main Aug 16, 2021
@roryabraham roryabraham deleted the ionatan_blocker_slacknotification branch August 16, 2021 16:34
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants